Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/metrics/net/network_metrics_provider.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/dom_distiller/standalone/content_extractor_browsertest.cc ('K') | « components/history/core/browser/top_sites_database.cc ('k') | components/metrics/serialization/metric_sample.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/net/network_metrics_provider.cc
diff --git a/components/metrics/net/network_metrics_provider.cc b/components/metrics/net/network_metrics_provider.cc
index 12054a9d2ad2260e2381ac4dc7ee7c353aaface5..6817d36dc2fd3195d8ed7016778cbeb63bfdb672 100644
--- a/components/metrics/net/network_metrics_provider.cc
+++ b/components/metrics/net/network_metrics_provider.cc
@@ -226,13 +226,10 @@ void NetworkMetricsProvider::WriteWifiAccessPointProto(
return;
// Parse OUI list.
- std::vector<std::string> oui_list;
- base::SplitString(info.oui_list, ' ', &oui_list);
- for (std::vector<std::string>::const_iterator it = oui_list.begin();
- it != oui_list.end();
- ++it) {
+ for (const base::StringPiece& oui_str : base::SplitStringPiece(
+ info.oui_list, " ", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
yzshen1 2015/07/22 22:50:34 TRIM_WHITESPACE
uint32 oui;
- if (base::HexStringToUInt(*it, &oui))
+ if (base::HexStringToUInt(oui_str, &oui))
vendor->add_element_identifier(oui);
else
NOTREACHED();
« components/dom_distiller/standalone/content_extractor_browsertest.cc ('K') | « components/history/core/browser/top_sites_database.cc ('k') | components/metrics/serialization/metric_sample.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698