components/translate/core/browser/translate_manager.cc - Issue 1234973004: Update SplitString calls in components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_manager.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_manager.cc

diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc

index 6b9abee8850081c3c5430aa0187c0208f061038c..9eb0ea1e1e3cd7efba89019346a338c6ba316b8d 100644

--- a/components/translate/core/browser/translate_manager.cc

+++ b/components/translate/core/browser/translate_manager.cc

@@ -144,9 +144,9 @@ void TranslateManager::InitiateTranslation(const std::string& page_lang) {

}

// Get the accepted languages list.

- std::vector<std::string> accept_languages_list;

- base::SplitString(prefs->GetString(accept_languages_pref_name_.c_str()), ',',

- &accept_languages_list);

+ std::vector<std::string> accept_languages_list = base::SplitString(

+ prefs->GetString(accept_languages_pref_name_), ",",

+ base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);

std::string target_lang = GetTargetLanguage(accept_languages_list);

std::string language_code =