Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index 3d67fc701704b4437d67d557c5a8162e7b84c081..829dc175a35dc50414d86db446d61ed153cbceef 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -1557,12 +1557,9 @@ class PexeDownloader : public blink::WebURLLoaderClient {
std::string cache_control =
response.httpHeaderField("cache-control").utf8();
- std::vector<std::string> values;
- base::SplitString(cache_control, ',', &values);
- for (std::vector<std::string>::const_iterator it = values.begin();
- it != values.end();
- ++it) {
- if (base::StringToLowerASCII(*it) == "no-store")
+ for (const std::string& cur : base::SplitString(
+ cache_control, ",", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ if (base::StringToLowerASCII(cur) == "no-store")
has_no_store_header = true;
}

Powered by Google App Engine
This is Rietveld 408576698