Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/metrics/serialization/serialization_utils.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/metrics/net/network_metrics_provider.cc ('K') | « components/metrics/serialization/metric_sample.cc ('k') | components/nacl/browser/nacl_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/serialization/serialization_utils.cc
diff --git a/components/metrics/serialization/serialization_utils.cc b/components/metrics/serialization/serialization_utils.cc
index 5dc71a44f76c01f7a276f25bd362c598986184d6..bd28f9f70bfb20d75cf522603572206f670c8469 100644
--- a/components/metrics/serialization/serialization_utils.cc
+++ b/components/metrics/serialization/serialization_utils.cc
@@ -91,8 +91,9 @@ scoped_ptr<MetricSample> SerializationUtils::ParseSample(
if (sample.empty())
return scoped_ptr<MetricSample>();
- std::vector<std::string> parts;
- base::SplitString(sample, '\0', &parts);
+ std::vector<std::string> parts = base::SplitString(
+ sample, std::string(1, '\0'),
+ base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
// We should have two null terminated strings so split should produce
// three chunks.
if (parts.size() != 3) {
« components/metrics/net/network_metrics_provider.cc ('K') | « components/metrics/serialization/metric_sample.cc ('k') | components/nacl/browser/nacl_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698