Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/history/core/browser/top_sites_database.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/top_sites_database.cc
diff --git a/components/history/core/browser/top_sites_database.cc b/components/history/core/browser/top_sites_database.cc
index d1f024d315a690fe8a6c37c0bea0132009b19970..00c45592ed2e6a54153b26455311602462678d84 100644
--- a/components/history/core/browser/top_sites_database.cc
+++ b/components/history/core/browser/top_sites_database.cc
@@ -90,12 +90,12 @@ std::string GetRedirects(const MostVisitedURL& url) {
// Decodes redirects from a string and sets them for the url.
void SetRedirects(const std::string& redirects, MostVisitedURL* url) {
- std::vector<std::string> redirects_vector;
- base::SplitStringAlongWhitespace(redirects, &redirects_vector);
- for (size_t i = 0; i < redirects_vector.size(); ++i) {
- GURL redirects_url(redirects_vector[i]);
- if (redirects_url.is_valid())
- url->redirects.push_back(redirects_url);
+ for (const std::string& redirect : base::SplitString(
+ redirects, base::kWhitespaceASCII,
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY)) {
+ GURL redirect_url(redirect);
+ if (redirect_url.is_valid())
+ url->redirects.push_back(redirect_url);
}
}

Powered by Google App Engine
This is Rietveld 408576698