Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: components/search_engines/default_search_manager_unittest.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_manager_unittest.cc
diff --git a/components/search_engines/default_search_manager_unittest.cc b/components/search_engines/default_search_manager_unittest.cc
index 02e15a69c80ce69181e779b056b8ca05a331a5a4..6687ba3c9f9b8e5d74575f0512937fd1a560af66 100644
--- a/components/search_engines/default_search_manager_unittest.cc
+++ b/components/search_engines/default_search_manager_unittest.cc
@@ -129,7 +129,8 @@ scoped_ptr<TemplateURLData> GenerateDummyTemplateURLData(std::string type) {
data->favicon_url = GURL("http://icon1");
data->safe_for_autoreplace = true;
data->show_in_default_list = true;
- base::SplitString("UTF-8;UTF-16", ';', &data->input_encodings);
+ data->input_encodings = base::SplitString(
+ "UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data->date_created = base::Time();
data->last_modified = base::Time();
return data.Pass();
@@ -170,7 +171,8 @@ TEST_F(DefaultSearchManagerTest, ReadAndWritePref) {
data.favicon_url = GURL("http://icon1");
data.safe_for_autoreplace = true;
data.show_in_default_list = true;
- base::SplitString("UTF-8;UTF-16", ';', &data.input_encodings);
+ data.input_encodings = base::SplitString(
+ "UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data.date_created = base::Time();
data.last_modified = base::Time();
« no previous file with comments | « components/query_parser/snippet_unittest.cc ('k') | components/search_engines/default_search_pref_migration.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698