Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: components/omnibox/browser/autocomplete_input.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/autocomplete_input.cc
diff --git a/components/omnibox/browser/autocomplete_input.cc b/components/omnibox/browser/autocomplete_input.cc
index d254b6106bd77584fa220d7c85deeabf5d9988a7..c8b744a5ec4872992ff70408d7938765ce94215a 100644
--- a/components/omnibox/browser/autocomplete_input.cc
+++ b/components/omnibox/browser/autocomplete_input.cc
@@ -37,14 +37,14 @@ void AdjustCursorPositionIfNecessary(size_t num_leading_chars_removed,
void PopulateTermsPrefixedByHttpOrHttps(
const base::string16& text,
std::vector<base::string16>* terms_prefixed_by_http_or_https) {
- std::vector<base::string16> terms;
// Split on whitespace rather than use ICU's word iterator because, for
// example, ICU's iterator may break on punctuation (such as ://) or decide
// to split a single term in a hostname (if it seems to think that the
// hostname is multiple words). Neither of these behaviors is desirable.
- base::SplitString(text, ' ', &terms);
const std::string separator(url::kStandardSchemeSeparator);
- for (const auto& term : terms) {
+ for (const auto& term :
+ base::SplitString(text, base::ASCIIToUTF16(" "),
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
const std::string term_utf8(base::UTF16ToUTF8(term));
static const char* kSchemes[2] = { url::kHttpScheme, url::kHttpsScheme };
for (const char* scheme : kSchemes) {
« no previous file with comments | « components/nacl/zygote/nacl_fork_delegate_linux.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698