Chromium Code Reviews| Index: Source/modules/webgl/WebGLExtension.h |
| diff --git a/Source/modules/webgl/WebGLExtension.h b/Source/modules/webgl/WebGLExtension.h |
| index fb7c2f049ec47cd2708687a4335658768bc17742..770b9b1ca8647a67181d2616e82cffa9fa688b5d 100644 |
| --- a/Source/modules/webgl/WebGLExtension.h |
| +++ b/Source/modules/webgl/WebGLExtension.h |
| @@ -35,9 +35,8 @@ |
| namespace blink { |
| -class WebGLExtensionScopedContext : public NoBaseWillBeGarbageCollectedFinalized<WebGLExtensionScopedContext> { |
| +class WebGLExtensionScopedContext : public GarbageCollectedFinalized<WebGLExtensionScopedContext> { |
|
sof
2015/08/01 18:49:13
Can't we make this just STACK_ALLOCATED()?
peria
2015/08/03 09:00:36
Done.
|
| WTF_MAKE_NONCOPYABLE(WebGLExtensionScopedContext); |
| - WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(WebGLExtensionScopedContext); |
| public: |
| WebGLExtensionScopedContext(WebGLExtension*); |
|
sof
2015/08/01 18:49:13
add explicit
peria
2015/08/03 09:00:36
Done.
|
| virtual ~WebGLExtensionScopedContext(); |
| @@ -51,8 +50,7 @@ private: |
| RefPtrWillBeMember<WebGLRenderingContextBase> m_context; |
| }; |
| -class WebGLExtension : public RefCountedWillBeGarbageCollectedFinalized<WebGLExtension>, public ScriptWrappable { |
| - WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(WebGLExtension); |
| +class WebGLExtension : public GarbageCollectedFinalized<WebGLExtension>, public ScriptWrappable { |
| public: |
| virtual ~WebGLExtension(); |
| virtual WebGLExtensionName name() const = 0; |
| @@ -83,7 +81,7 @@ protected: |
| private: |
| friend WebGLExtensionScopedContext; |
| - RawPtrWillBeWeakMember<WebGLRenderingContextBase> m_context; |
| + RefPtrWillBeWeakMember<WebGLRenderingContextBase> m_context; |
|
sof
2015/08/01 18:49:13
Could you explain why this needs to be a RefPtr<>
peria
2015/08/03 09:00:36
I reverted this change.
I'm not sure why I did thi
|
| }; |
| } // namespace blink |