[Oilpan] Migrate classes under module/webgl onto oilpan heap

Source/modules/webgl/WebGLExtension.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  */
 
 #ifndef WebGLExtension_h
 #define WebGLExtension_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/html/HTMLCanvasElement.h"
 #include "modules/webgl/WebGLExtensionName.h"
 #include "modules/webgl/WebGLRenderingContextBase.h"
 #include "platform/heap/Handle.h"
 #include "wtf/RefCounted.h"

[sof, 2015/08/01 18:49:13]

Can be removed.

[peria, 2015/08/03 09:00:36]

Done.

 
 namespace blink {
 
-class WebGLExtensionScopedContext : public NoBaseWillBeGarbageCollectedFinalized<WebGLExtensionScopedContext> {
+class WebGLExtensionScopedContext : public GarbageCollectedFinalized<WebGLExtensionScopedContext> {

[sof, 2015/08/01 18:49:13]

Can't we make this just STACK_ALLOCATED()?

[peria, 2015/08/03 09:00:36]

Done.

     WTF_MAKE_NONCOPYABLE(WebGLExtensionScopedContext);
-    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(WebGLExtensionScopedContext);
 public:
     WebGLExtensionScopedContext(WebGLExtension*);

[sof, 2015/08/01 18:49:13]

add explicit

[peria, 2015/08/03 09:00:36]

Done.

     virtual ~WebGLExtensionScopedContext();
 
     bool isLost() { return !m_context; }
     WebGLRenderingContextBase* context() const { return m_context.get(); }
 
     DECLARE_VIRTUAL_TRACE();
 
 private:
     RefPtrWillBeMember<WebGLRenderingContextBase> m_context;
 };
 
-class WebGLExtension : public RefCountedWillBeGarbageCollectedFinalized<WebGLExtension>, public ScriptWrappable {
-    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(WebGLExtension);
+class WebGLExtension : public GarbageCollectedFinalized<WebGLExtension>, public ScriptWrappable {
 public:
     virtual ~WebGLExtension();
     virtual WebGLExtensionName name() const = 0;
 
     // Lose this extension. Passing true = force loss. Some extensions
     // like WEBGL_lose_context are not normally lost when the context
     // is lost but must be lost when destroying their WebGLRenderingContextBase.
     virtual void lose(bool)
     {
         m_context = nullptr;
@@ skipping 10 matching lines @@
             return m_context->canvas();
         return nullptr;
     }
 
 protected:
     explicit WebGLExtension(WebGLRenderingContextBase*);
 
 private:
     friend WebGLExtensionScopedContext;
 
-    RawPtrWillBeWeakMember<WebGLRenderingContextBase> m_context;
+    RefPtrWillBeWeakMember<WebGLRenderingContextBase> m_context;

[sof, 2015/08/01 18:49:13]

Could you explain why this needs to be a RefPtr<> for the time being non-Oilpan
& why that doesn't bring about any ref cycles?

[peria, 2015/08/03 09:00:36]

I reverted this change.
I'm not sure why I did this change...

 };
 
 } // namespace blink
 
 #endif // WebGLExtension_h