[BlobAsync] Asynchronous Blob Construction Final Patch

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4540b3842452bb83908eb0bc17e1968bd9be9f3d..8fdaf9544622c07cb401ef346f8c553e325df8dc 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -49945,6 +49945,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Storage.Blob.Broken" units="BooleanBroken">
+  <owner>dmurph@chromium.org</owner>
+  <summary>
+    If a newly constructed blob is broken. See Storage.Blob.BrokenReason for a
+    the broken reasons.
+  </summary>
+</histogram>
+
+<histogram name="Storage.Blob.BrokenReason" units="BlobBrokenReason">
+  <owner>dmurph@chromium.org</owner>
+  <summary>
+    The reason a blob is broken, reported only for broken blobs. See

[Mark P, 2016/03/15 18:36:06]

nit: before period add "upon construction" for clarity (if that's true).

[dmurph, 2016/03/15 22:40:15]

Done.

+    Storage.Blob.Broken for the number of blobs broken.

[Mark P, 2016/03/15 18:36:06]

nit: it's not necessary to see Storage.Blob.Broken for the number of blobs
broken.  You can simply add up these counts.  You probably meant something like
"See Storage.Blob.Broken for the breakdown of blobs broken versus unbroken."

[dmurph, 2016/03/15 22:40:15]

Done.

+  </summary>
+</histogram>
+
 <histogram name="Storage.Blob.ExceededMemory" enum="Boolean">
   <owner>dmurph@chromium.org</owner>
   <summary>
@@ -59943,6 +59959,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="111" label="WSH_SEND_FRAME_DURING_BLOB_SEND"/>
   <int value="112" label="RFH_UNEXPECTED_LOAD_START"/>
   <int value="113" label="NMF_INVALID_ARGUMENT"/>
+  <int value="114" label="RFH_INVALID_ORIGIN_ON_COMMIT"/>
+  <int value="115" label="BDH_UUID_REGISTERED"/>
+  <int value="116" label="BDH_CONSTRUCTION_FAILED"/>
+  <int value="117" label="BDH_INVALID_OPERATION"/>
 </enum>
 
 <enum name="BadMessageReasonExtensions" type="int">
@@ -60030,6 +60050,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="5" label="Blacklist disabled."/>
 </enum>
 
+<enum name="BlobBrokenReason" type="int">
+  <int value="0" label="Unknown"/>
+  <int value="1" label="File write failed"/>

[Mark P, 2016/03/15 18:36:06]

These value don't line up with the C++ enum that I think they're supposed to.

This is a warning flag for me.  Did you actually test the reason values for
failures using about:histograms to see if the recorded failure is what you
expect?

[dmurph, 2016/03/15 22:40:15]

Thanks, fixed and verified.

+  <int value="2" label="Source died in transit"/>
+  <int value="3" label="Blob dereferenced while building"/>
+  <int value="4" label="Referenced blob broken"/>
+</enum>
+
 <enum name="BluetoothAvailability" type="int">
   <int value="0" label="Unexpected error"/>
   <int value="1" label="Not available"/>
@@ -60165,6 +60193,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="1" label="Notification click (within last 5 seconds)"/>
 </enum>
 
+<enum name="BooleanBroken" type="int">
+  <int value="0" label="Not Broken"/>
+  <int value="1" label="Broken"/>
+</enum>
+
 <enum name="BooleanCacheHit" type="int">
   <int value="0" label="Miss"/>
   <int value="1" label="Hit"/>