content/browser/indexed_db/indexed_db_browsertest.cc - Issue 1234813004: [BlobAsync] Asynchronous Blob Construction Final Patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_browsertest.cc

Issue 1234813004: [BlobAsync] Asynchronous Blob Construction Final Patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blob-protocol-change

Patch Set: added shared memory test, and fixed memory leak Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/manifest.json ('K') | « content/browser/fileapi/fileapi_message_filter.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | storage/browser/blob/blob_async_builder_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_browsertest.cc

diff --git a/content/browser/indexed_db/indexed_db_browsertest.cc b/content/browser/indexed_db/indexed_db_browsertest.cc

index c23be28002c4b19dfa49124dee911faa7115f4d0..b8dd4c2148ab35a119466700948e6ea13154a298 100644

--- a/content/browser/indexed_db/indexed_db_browsertest.cc

+++ b/content/browser/indexed_db/indexed_db_browsertest.cc

@@ -446,11 +446,7 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, EmptyBlob) {

// For some reason Android's futimes fails (EPERM) in this test. Do not assert

// file times on Android, but do so on other platforms. crbug.com/467247

// TODO(cmumford): Figure out why this is the case and fix if possible.

-#if defined(OS_ANDROID)

- SimpleTest(GURL(test_url.spec() + "#ignoreTimes"));

-#else

SimpleTest(GURL(test_url.spec()));

-#endif

// Test stores one blob and one file to disk, so expect two files.

EXPECT_EQ(2, RequestBlobFileCount());

}