Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1234753002: Revert "Teach i18nTemplate.process() to handle <link rel=import> and <template>" (Closed)

Created:
5 years, 5 months ago by dzhioev (left Google)
Modified:
5 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Teach i18nTemplate.process() to handle <link rel=import> and <template>" The reverted commit broke i18n-values substitution in OOBE UI. This reverts commit b163dffbb26ab34a52a29e2dc8ccd00d0dbac431. > Author: dbeam <dbeam@chromium.org>; > Date: Wed Jul 8 20:33:13 2015 -0700 > > Teach i18nTemplate.process() to handle <link rel=import> and > <template> > > This is required to support Polymerized web UI until we figure out > a > more flicker-resistant solution (see: crbug.com/506009) > > BUG=425626 > R=arv@chromium.org > TBR=yoshiki@chromium.org > > Review URL: https://codereview.chromium.org/1229573003 > > Cr-Commit-Position: refs/heads/master@{#337980} BUG=425626, 509087 TBR=dbeam NOPRESUBIT=true Committed: https://crrev.com/2ef4e14f1b6c9d59e29978e5a16baaedb3c22ab6 Cr-Commit-Position: refs/heads/master@{#338431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -116 lines) Patch
M chrome/browser/resources/bookmark_manager/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/webui/i18n_process_test.html View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/chrome_apps/webstore_widget/app/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/externs/compiled_resources.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/closure_compiler/externs/pending_compiler_externs.js View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/compiled_resources.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/webui/resources/js/compiled_resources2.gyp View 1 chunk +2 lines, -10 lines 0 comments Download
M ui/webui/resources/js/i18n_template_no_process.js View 3 chunks +10 lines, -23 lines 0 comments Download
M ui/webui/resources/js/webui_resource_test.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234753002/1
5 years, 5 months ago (2015-07-11 02:07:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234753002/1
5 years, 5 months ago (2015-07-11 02:13:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-11 03:14:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2ef4e14f1b6c9d59e29978e5a16baaedb3c22ab6 Cr-Commit-Position: refs/heads/master@{#338431}
5 years, 5 months ago (2015-07-11 03:15:38 UTC) #7
Dan Beam
> The reverted commit broke i18n-values substitution in OOBE UI. how?
5 years, 5 months ago (2015-07-13 17:26:35 UTC) #9
achuithb
5 years, 5 months ago (2015-07-13 20:57:16 UTC) #10
Message was sent while issue was closed.
On 2015/07/13 17:26:35, Dan Beam wrote:
> > The reverted commit broke i18n-values substitution in OOBE UI.
> 
> how?

Incidentally this revert did not make it into M-45

Powered by Google App Engine
This is Rietveld 408576698