Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1234713002: win/clang: Roll clang 239674:242415 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 242415 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/clang/scripts/update.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index fd586fd6ab44365866edcfb147ad97b57e5fcc0c..140e32936083c368169b14962e57a200389a4309 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -910,18 +910,10 @@ if (is_clang) {
default_warning_flags += [
# TODO(hans): Get this cleaned up, http://crbug.com/428099
"-Wno-inconsistent-missing-override",
- ]
- if (exec_script("//tools/clang/scripts/update.py",
- [ "--print-revision" ],
- "trim string") != "239674-1") {
- default_warning_flags += [
- # TODO(thakis): Move this into outer if once clang is rolled far enough
- # that the pinned clang understands this flag.
- # TODO(thakis): Enable this, crbug.com/507717
- "-Wno-shift-negative-value",
- ]
- }
+ # TODO(thakis): Enable this, crbug.com/507717
+ "-Wno-shift-negative-value",
+ ]
}
}
« no previous file with comments | « build/common.gypi ('k') | tools/clang/scripts/update.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698