Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1234683002: Convert some more |base::Lock|s to |mojo::system::Mutex|s. (Closed)

Created:
5 years, 5 months ago by viettrungluu
Modified:
5 years, 5 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert some more |base::Lock|s to |mojo::system::Mutex|s. I'm going to run out of easy conversions soon. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c7cbdd24b9ba46d91c4751590b93c895108a25a5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M mojo/edk/system/core_test_base.h View 2 chunks +19 lines, -19 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +33 lines, -33 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.h View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.cc View 3 chunks +5 lines, -4 lines 1 comment Download
M mojo/edk/system/incoming_endpoint.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 5 months ago (2015-07-10 21:44:03 UTC) #1
kulakowski
lgtm https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_relayer.cc File mojo/edk/system/endpoint_relayer.cc (right): https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_relayer.cc#newcode25 mojo/edk/system/endpoint_relayer.cc:25: MOJO_NO_THREAD_SAFETY_ANALYSIS { I wonder if this pattern (having ...
5 years, 5 months ago (2015-07-10 21:53:47 UTC) #2
viettrungluu
On 2015/07/10 21:53:47, kulakowski wrote: > lgtm > > https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_relayer.cc > File mojo/edk/system/endpoint_relayer.cc (right): > ...
5 years, 5 months ago (2015-07-10 22:14:28 UTC) #3
viettrungluu
5 years, 5 months ago (2015-07-10 22:14:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7cbdd24b9ba46d91c4751590b93c895108a25a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698