Convert some more |base::Lock|s to |mojo::system::Mutex|s.

Convert some more |base::Lock|s to |mojo::system::Mutex|s.

I'm going to run out of easy conversions soon.

R=kulakowski@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c7cbdd24b9ba46d91c4751590b93c895108a25a5

[kulakowski, 2015-07-10 21:53:47]

lgtm

https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_re...
File mojo/edk/system/endpoint_relayer.cc (right):

https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_re...
mojo/edk/system/endpoint_relayer.cc:25: MOJO_NO_THREAD_SAFETY_ANALYSIS {
I wonder if this pattern (having to make |Init| functions
MOJO_NO_THREAD_SAFETY_ANALYSIS) is a pattern to be documented somewhere? It
feels a bit more subtle than MOJO_GUARDED_BY.

[viettrungluu, 2015-07-10 22:14:28]

On 2015/07/10 21:53:47, kulakowski wrote:
> lgtm
> 
>
https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_re...
> File mojo/edk/system/endpoint_relayer.cc (right):
> 
>
https://codereview.chromium.org/1234683002/diff/1/mojo/edk/system/endpoint_re...
> mojo/edk/system/endpoint_relayer.cc:25: MOJO_NO_THREAD_SAFETY_ANALYSIS {
> I wonder if this pattern (having to make |Init| functions
> MOJO_NO_THREAD_SAFETY_ANALYSIS) is a pattern to be documented somewhere? It
> feels a bit more subtle than MOJO_GUARDED_BY.

Maybe. At some level, Init() is kind of a logical extension of the constructor
(since the Google style guide discourages nontrivial work in the constructor),
so one shouldn't expect it to be any more thread-safe than the constructor. (I
usually have a comment somewhere saying something like "no other methods may be
called before Init()", which pretty much implies a lack of thread-safety.)

[viettrungluu, 2015-07-10 22:14:56]

Committed patchset #1 (id:1) manually as
c7cbdd24b9ba46d91c4751590b93c895108a25a5 (presubmit successful).