Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: mojo/edk/system/waiter_unittest.cc

Issue 1234683002: Convert some more |base::Lock|s to |mojo::system::Mutex|s. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/waiter_unittest.cc
diff --git a/mojo/edk/system/waiter_unittest.cc b/mojo/edk/system/waiter_unittest.cc
index 68f81062e8174931259cf8e83cb094b921eac3d2..29bd5bcd48a4fc4d1188baf2ad4537483f313a94 100644
--- a/mojo/edk/system/waiter_unittest.cc
+++ b/mojo/edk/system/waiter_unittest.cc
@@ -11,8 +11,8 @@
#include <stdint.h>
-#include "base/synchronization/lock.h"
#include "base/threading/simple_thread.h"
+#include "mojo/edk/system/mutex.h"
#include "mojo/edk/system/test_utils.h"
#include "mojo/public/cpp/system/macros.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -41,7 +41,7 @@ class WaitingThread : public base::SimpleThread {
MojoDeadline* elapsed) {
for (;;) {
{
- base::AutoLock locker(lock_);
+ MutexLocker locker(&mutex_);
if (done_) {
*result = result_;
*context = context_;
@@ -68,7 +68,7 @@ class WaitingThread : public base::SimpleThread {
elapsed = stopwatch.Elapsed();
{
- base::AutoLock locker(lock_);
+ MutexLocker locker(&mutex_);
done_ = true;
result_ = result;
context_ = context;
@@ -79,11 +79,11 @@ class WaitingThread : public base::SimpleThread {
const MojoDeadline deadline_;
Waiter waiter_; // Thread-safe.
- base::Lock lock_; // Protects the following members.
- bool done_;
- MojoResult result_;
- uint32_t context_;
- MojoDeadline elapsed_;
+ Mutex mutex_;
+ bool done_ MOJO_GUARDED_BY(mutex_);
+ MojoResult result_ MOJO_GUARDED_BY(mutex_);
+ uint32_t context_ MOJO_GUARDED_BY(mutex_);
+ MojoDeadline elapsed_ MOJO_GUARDED_BY(mutex_);
MOJO_DISALLOW_COPY_AND_ASSIGN(WaitingThread);
};
« mojo/edk/system/endpoint_relayer.cc ('K') | « mojo/edk/system/test_channel_endpoint_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698