Issue 1234653002: Fix -Wreorder warnings in the Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234653002: Fix -Wreorder warnings in the Windows code. (Closed)

Created:
5 years, 5 months ago by Will Harris

Modified:
5 years, 5 months ago

Reviewers:

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Fix -Wreorder warnings in the Windows code. This makes the order of fields in constructor initializer lists match the order in which the fields are declared in (which is the order they're initialized in). No intended behavior change. This change was originally reviewed at https://codereview.chromium.org/1230923005/ BUG=chromium:505304 TBR=thakis@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1471

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	src/client/windows/crash_generation/crash_generation_client.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/client/windows/crash_generation/crash_generation_server.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/client/windows/crash_generation/minidump_generator.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (2 generated)

Will Harris

5 years, 5 months ago (2015-07-10 20:24:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r1471 (presubmit successful).