Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: src/client/windows/crash_generation/crash_generation_server.cc

Issue 1234653002: Fix -Wreorder warnings in the Windows code. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2008, Google Inc. 1 // Copyright (c) 2008, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 server_alive_handle_(NULL), 114 server_alive_handle_(NULL),
115 connect_callback_(connect_callback), 115 connect_callback_(connect_callback),
116 connect_context_(connect_context), 116 connect_context_(connect_context),
117 dump_callback_(dump_callback), 117 dump_callback_(dump_callback),
118 dump_context_(dump_context), 118 dump_context_(dump_context),
119 exit_callback_(exit_callback), 119 exit_callback_(exit_callback),
120 exit_context_(exit_context), 120 exit_context_(exit_context),
121 upload_request_callback_(upload_request_callback), 121 upload_request_callback_(upload_request_callback),
122 upload_context_(upload_context), 122 upload_context_(upload_context),
123 generate_dumps_(generate_dumps), 123 generate_dumps_(generate_dumps),
124 pre_fetch_custom_info_(true),
124 dump_path_(dump_path ? *dump_path : L""), 125 dump_path_(dump_path ? *dump_path : L""),
125 server_state_(IPC_SERVER_STATE_UNINITIALIZED), 126 server_state_(IPC_SERVER_STATE_UNINITIALIZED),
126 shutting_down_(false), 127 shutting_down_(false),
127 overlapped_(), 128 overlapped_(),
128 client_info_(NULL), 129 client_info_(NULL) {
129 pre_fetch_custom_info_(true) {
130 InitializeCriticalSection(&sync_); 130 InitializeCriticalSection(&sync_);
131 } 131 }
132 132
133 // This should never be called from the OnPipeConnected callback. 133 // This should never be called from the OnPipeConnected callback.
134 // Otherwise the UnregisterWaitEx call below will cause a deadlock. 134 // Otherwise the UnregisterWaitEx call below will cause a deadlock.
135 CrashGenerationServer::~CrashGenerationServer() { 135 CrashGenerationServer::~CrashGenerationServer() {
136 // New scope to release the lock automatically. 136 // New scope to release the lock automatically.
137 { 137 {
138 // Make sure no clients are added or removed beyond this point. 138 // Make sure no clients are added or removed beyond this point.
139 // Before adding or removing any clients, the critical section 139 // Before adding or removing any clients, the critical section
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 client.assert_info(), 922 client.assert_info(),
923 client.dump_type(), 923 client.dump_type(),
924 true); 924 true);
925 if (!dump_generator.GenerateDumpFile(dump_path)) { 925 if (!dump_generator.GenerateDumpFile(dump_path)) {
926 return false; 926 return false;
927 } 927 }
928 return dump_generator.WriteMinidump(); 928 return dump_generator.WriteMinidump();
929 } 929 }
930 930
931 } // namespace google_breakpad 931 } // namespace google_breakpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698