LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html - Issue 1234553003: Supports the sound attribute to the Notification object

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html

Issue 1234553003: Supports the sound attribute to the Notification object Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: [WIP] Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/notification-properties.html ('k') | LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html

diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html

similarity index 83%

copy from LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

copy to LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html

index b7827242c555110f279e48d349dd8aa481595060..3a0b9c023e053b539d2cd448f948308c8abb7663 100644

--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html

@@ -1,7 +1,7 @@

<!doctype html>

<html>

<head>

- <title>Notifications: Verifying the exception throwing behavior, when silent set true and vibrate is presented in showNotification().</title>

+ <title>Notifications: Verifying the exception throwing behavior, when silent set true and sound is presented in showNotification().</title>

@@ -9,7 +9,7 @@

<body>

// Tests that the showNotification() function rejects the returned promise with a

- // TypeError when silent set true and vibrate is presented.

+ // TypeError when silent set true and sound is presented.

async_test(function(test) {

var scope = 'resources/scope/' + location.pathname,

workerUrl = 'resources/empty-worker.js';

@@ -23,19 +23,19 @@

}).then(function() {

registration.showNotification('Title', {

body: 'Hello, world!',

- vibrate: [100, 200, 300],

+ sound: 'http://example.com/example.mp3',

silent: true

}).then(function() {

assert_unreached('showNotification() is expected to reject.');

}).catch(function(error) {

assert_equals(error.name, 'TypeError');

- assert_equals(error.message, 'Silent notifications must not specify vibration patterns.');

+ assert_equals(error.message, 'Silent notifications must not specify sound or vibration patterns.');

test.done();

});

}).catch(unreached_rejection(test));

- }, 'showNotification() must reject If options\'s silent is true, and options\'s vibrate is presenteded.');

+ }, 'showNotification() must reject If options\'s silent is true, and options\'s sound is presenteded.');

</script>

</body>

</html>