LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html - Issue 1234553003: Supports the sound attribute to the Notification object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

Issue 1234553003: Supports the sound attribute to the Notification object Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: [WIP] Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworkerregistration-document-sound-throw.html ('k') | Source/modules/notifications/Notification.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

index b7827242c555110f279e48d349dd8aa481595060..a5d099f2f24fe4f7f403db40f0b411469d98ef64 100644

--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

@@ -29,7 +29,7 @@

assert_unreached('showNotification() is expected to reject.');

}).catch(function(error) {

assert_equals(error.name, 'TypeError');

- assert_equals(error.message, 'Silent notifications must not specify vibration patterns.');

+ assert_equals(error.message, 'Silent notifications must not specify sound or vibration patterns.');

test.done();

});