[GCM] Add connection/persistent store metric collection

[GCM] Add connection/persistent store metric collection

Adds various metrics related to GCM connection stability and persistent store
usage.

BUG=284553
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243501

[Nicolas Zea, 2014-01-02 22:46:31]

PTAL. I'll add per-app metrics once the per-app limits are enforced (in a
separate patch), this one is focused on connection and persistent store metrics.

[jianli, 2014-01-02 23:22:20]

lgtm

[fgorski, 2014-01-02 23:45:40]

lgtm with a question

https://codereview.chromium.org/123453004/diff/30001/google_apis/gcm/engine/r...
File google_apis/gcm/engine/rmq_store.cc (right):

https://codereview.chromium.org/123453004/diff/30001/google_apis/gcm/engine/r...
google_apis/gcm/engine/rmq_store.cc:181: static_cast<int>(file_size / 1024));
That does not make a distinction between a 0 size store and a
1-1023B size store. Would that information be useful at any point?

[Nicolas Zea, 2014-01-02 23:48:21]

+Alexei for histograms.xml ownership.

https://codereview.chromium.org/123453004/diff/30001/google_apis/gcm/engine/r...
File google_apis/gcm/engine/rmq_store.cc (right):

https://codereview.chromium.org/123453004/diff/30001/google_apis/gcm/engine/r...
google_apis/gcm/engine/rmq_store.cc:181: static_cast<int>(file_size / 1024));
On 2014/01/02 23:45:40, Filip Gorski wrote:
> That does not make a distinction between a 0 size store and a
> 1-1023B size store. Would that information be useful at any point?

A 0 store should not happen if the store has been initialized with an android id
and security token (which we verify above), so I don't think it's useful to
distinguish. And I'm not sure this is an interesting metric for those users who
aren't signed in and therefore don't have GCM initialized.

[fgorski, 2014-01-03 00:16:45]

On 2014/01/02 23:48:21, Nicolas Zea wrote:
> +Alexei for histograms.xml ownership.
> 
>
https://codereview.chromium.org/123453004/diff/30001/google_apis/gcm/engine/r...
> File google_apis/gcm/engine/rmq_store.cc (right):
> 
>
https://codereview.chromium.org/123453004/diff/30001/google_apis/gcm/engine/r...
> google_apis/gcm/engine/rmq_store.cc:181: static_cast<int>(file_size / 1024));
> On 2014/01/02 23:45:40, Filip Gorski wrote:
> > That does not make a distinction between a 0 size store and a
> > 1-1023B size store. Would that information be useful at any point?
> 
> A 0 store should not happen if the store has been initialized with an android
id
> and security token (which we verify above), so I don't think it's useful to
> distinguish. And I'm not sure this is an interesting metric for those users
who
> aren't signed in and therefore don't have GCM initialized.

Makes sense.

[Alexei Svitkine (slow), 2014-01-06 15:49:50]

lgtm

[commit-bot: I haz the power, 2014-01-06 18:45:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/123453004/30001

[commit-bot: I haz the power, 2014-01-07 23:42:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/123453004/320001

[commit-bot: I haz the power, 2014-01-08 02:40:32]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 03:07:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/123453004/320001

[commit-bot: I haz the power, 2014-01-08 06:26:57]

Change committed as 243501