[GCM] Add connection/persistent store metric collection

google_apis/gcm/engine/rmq_store.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/rmq_store.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback.h"
+#include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop_proxy.h"
+#include "base/metrics/histogram.h"
 #include "base/sequenced_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/tracked_objects.h"
 #include "components/webdata/encryptor/encryptor.h"
 #include "google_apis/gcm/base/mcs_message.h"
 #include "google_apis/gcm/base/mcs_util.h"
 #include "google_apis/gcm/protocol/mcs.pb.h"
 #include "third_party/leveldatabase/src/include/leveldb/db.h"
@@ skipping 114 matching lines @@
 
 void RMQStore::Backend::Load(const LoadCallback& callback) {
   LoadResult result;
 
   leveldb::Options options;
   options.create_if_missing = true;
   leveldb::DB* db;
   leveldb::Status status = leveldb::DB::Open(options,
                                              path_.AsUTF8Unsafe(),
                                              &db);
+  UMA_HISTOGRAM_BOOLEAN("GCM.LoadSucceeded", status.ok());
   if (!status.ok()) {
     LOG(ERROR) << "Failed to open database " << path_.value()
                << ": " << status.ToString();
     foreground_task_runner_->PostTask(FROM_HERE,
                                       base::Bind(callback, result));
     return;
   }
   db_.reset(db);
 
   if (!LoadDeviceCredentials(&result.device_android_id,
                              &result.device_security_token) ||
       !LoadIncomingMessages(&result.incoming_messages) ||
       !LoadOutgoingMessages(&result.outgoing_messages) ||
       !LoadNextSerialNumber(&result.next_serial_number) ||
       !LoadUserSerialNumberMap(&result.user_serial_numbers)) {
     result.device_android_id = 0;
     result.device_security_token = 0;
     result.incoming_messages.clear();
     STLDeleteContainerPairSecondPointers(result.outgoing_messages.begin(),
                                          result.outgoing_messages.end());
     result.outgoing_messages.clear();
     foreground_task_runner_->PostTask(FROM_HERE,
                                       base::Bind(callback, result));
     return;
   }
 
+  // Only record histograms if GCM had already been set up for this device.
+  if (result.device_android_id != 0 && result.device_security_token != 0) {
+    int64 file_size = 0;
+    if (base::GetFileSize(path_, &file_size)) {
+      UMA_HISTOGRAM_COUNTS("GCM.StoreSizeKB",
+                           static_cast<int>(file_size / 1024));

[fgorski, 2014/01/02 23:45:40]

That does not make a distinction between a 0 size store and a
1-1023B size store. Would that information be useful at any point?

[Nicolas Zea, 2014/01/02 23:48:21]

A 0 store should not happen if the store has been initialized with an android id
and security token (which we verify above), so I don't think it's useful to
distinguish. And I'm not sure this is an interesting metric for those users who
aren't signed in and therefore don't have GCM initialized.

+    }
+    UMA_HISTOGRAM_COUNTS("GCM.RestoredOutgoingMessages",
+                         result.outgoing_messages.size());
+    UMA_HISTOGRAM_COUNTS("GCM.RestoredIncomingMessages",
+                         result.incoming_messages.size());
+    UMA_HISTOGRAM_COUNTS("GCM.NumUsers", result.user_serial_numbers.size());
+  }
+
   DVLOG(1) << "Succeeded in loading " << result.incoming_messages.size()
           << " unacknowledged incoming messages and "
           << result.outgoing_messages.size()
           << " unacknowledged outgoing messages.";
   result.success = true;
   foreground_task_runner_->PostTask(FROM_HERE,
                                     base::Bind(callback, result));
   return;
 }
 
@@ skipping 466 matching lines @@
                                       const UpdateCallback& callback) {
   blocking_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&RMQStore::Backend::RemoveUserSerialNumber,
                  backend_,
                  username,
                  callback));
 }
 
 }  // namespace gcm