Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1234513004: Make follow the same pattern for equalSelections() in VisibleSelection. (Closed)

Created:
5 years, 5 months ago by hyup
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

This CL adds equalSelectionsAlgorithm() which is called in equalSelections() for both composed tree and DOM tree. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199195

Patch Set 1 #

Total comments: 3

Patch Set 2 : Make follow the same pattern for equalSelections() in visibleSelection. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M Source/core/editing/VisibleSelection.cpp View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
hyup
PTAL
5 years, 5 months ago (2015-07-16 05:17:11 UTC) #2
yosin_UTC9
https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp File Source/core/editing/VisibleSelection.cpp (right): https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp#newcode1154 Source/core/editing/VisibleSelection.cpp:1154: return a.startInComposedTree() == b.startInComposedTree() && a.endInComposedTree() == b.endInComposedTree() && ...
5 years, 5 months ago (2015-07-16 07:24:20 UTC) #4
hyup
https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp File Source/core/editing/VisibleSelection.cpp (right): https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp#newcode1154 Source/core/editing/VisibleSelection.cpp:1154: return a.startInComposedTree() == b.startInComposedTree() && a.endInComposedTree() == b.endInComposedTree() && ...
5 years, 5 months ago (2015-07-16 09:41:02 UTC) #5
yosin_UTC9
https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp File Source/core/editing/VisibleSelection.cpp (right): https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp#newcode1154 Source/core/editing/VisibleSelection.cpp:1154: return a.startInComposedTree() == b.startInComposedTree() && a.endInComposedTree() == b.endInComposedTree() && ...
5 years, 5 months ago (2015-07-17 01:06:07 UTC) #6
hyup
On 2015/07/17 01:06:07, Yosi_UTC9 wrote: > https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp > File Source/core/editing/VisibleSelection.cpp (right): > > https://codereview.chromium.org/1234513004/diff/1/Source/core/editing/VisibleSelection.cpp#newcode1154 > ...
5 years, 5 months ago (2015-07-19 16:24:01 UTC) #7
yosin_UTC9
lgtm Thanks!
5 years, 5 months ago (2015-07-21 01:10:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234513004/20001
5 years, 5 months ago (2015-07-21 01:10:15 UTC) #10
commit-bot: I haz the power
The author sh53.lee@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-21 01:10:19 UTC) #11
commit-bot: I haz the power
The author sh53.lee@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-21 01:31:04 UTC) #12
commit-bot: I haz the power
The author sh53.lee@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-21 02:01:24 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 02:19:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199195

Powered by Google App Engine
This is Rietveld 408576698