Make follow the same pattern for equalSelections() in VisibleSelection.

Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1128 matching lines @@
 }
 
 bool VisibleSelection::InDOMTree::equalSelections(const VisibleSelection& selection1, const VisibleSelection& selection2)
 {
     if (selection1.affinity() != selection2.affinity() || selection1.isDirectional() != selection2.isDirectional())
         return false;
 
     if (selection1.isNone())
         return selection2.isNone();
 
-    return selection1.start() == selection2.start() && selection1.end() == selection2.end() && selection1.affinity() == selection2.affinity()
-        && selection1.isDirectional() == selection2.isDirectional() && selection1.base() == selection2.base() && selection1.extent() == selection2.extent();
+    return selection1.start() == selection2.start() && selection1.end() == selection2.end() && selection1.base() == selection2.base() && selection1.extent() == selection2.extent();
 }
 
 bool VisibleSelection::InComposedTree::equalSelections(const VisibleSelection& a, const VisibleSelection& b)
 {
     return a.startInComposedTree() == b.startInComposedTree() && a.endInComposedTree() == b.endInComposedTree() && a.affinity() == b.affinity() && a.isBaseFirst() == b.isBaseFirst() && a.isDirectional() == b.isDirectional();

[yosin_UTC9, 2015/07/16 07:24:20]

Could you get rid of duplicate conditions here too?

[hyup, 2015/07/16 09:41:02]

I removed conditions about affinity and isDirectional in
VisibleSelection::InDOMTree::equalSelections because of 1143 line. But I'm not
sure in here. Could you explain which conditions should I remove here?

[yosin_UTC9, 2015/07/17 01:06:07]

Oops, composed tree version isn't matched DOM tree version. This is bad.
We should follow the pattern using equalSelectionsAlgorithm.
So, equalSelections should be:

template <typename Strategy>
static bool equalSelectionsAlgorithm(const VisbileSelection& selection1, const
VisbileSelection& selection2)
{
    if (selection1.affinity() != selection2.affinity() ||
selection1.isDirectional() != selection2.isDirectional())
        return false;
    if (selection1.isNone())
        return selection2.isNone();
    return Strategy::selectionStart(selection1) ==
Strategy::selectionStart(selection2) && Strategy::selectionEnd(selection1) ==
Strategy::selectionEnd(selection2) && Strategy::selectionBase(selection1) ==
Strategy::selectionBase(selection2) && Strategy::selectionExtent(selection1) ==
Strategy::selectionExtent(selection2);
}

bool VisbileSelection::InDOMTree::equalSelections(const VisbileSelection&
selection1, const VisbileSelection& selection2)
{
    return equalSelectionsAlgorithm<InDOMTree>(selection1, selection2);
}

bool VisbileSelection::InComposedTree::equalSelections(const VisbileSelection&
selection1, const VisbileSelection& selection2)
{
    return equalSelectionsAlgorithm<InComposedTree>(selection1, selection2);
}

 }
 
 #ifndef NDEBUG
 
 void VisibleSelection::debugPosition(const char* message) const
 {
     fprintf(stderr, "VisibleSelection (%s) ===============\n", message);
 
     if (m_baseIsFirst) {
         m_start.debugPosition("start: ");
@@ skipping 66 matching lines @@
     sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
 }
 
 #endif