Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1234483002: clang/win: Build without -Wno-reorder. (Closed)

Created:
5 years, 5 months ago by Sam McNally
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Build without -Wno-reorder. BUG=505304 Committed: https://crrev.com/c36d3c7ef4f7d38d97133d2d0536d6f5e94c2fb0 Cr-Commit-Position: refs/heads/master@{#338218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Sam McNally
5 years, 5 months ago (2015-07-10 00:08:11 UTC) #2
Nico
lgtm!
5 years, 5 months ago (2015-07-10 00:08:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234483002/1
5 years, 5 months ago (2015-07-10 00:11:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 02:41:28 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 02:43:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c36d3c7ef4f7d38d97133d2d0536d6f5e94c2fb0
Cr-Commit-Position: refs/heads/master@{#338218}

Powered by Google App Engine
This is Rietveld 408576698