Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1223363004: clang/win: Build without -Wno-pointer-sign. (Closed)

Created:
5 years, 5 months ago by Sam McNally
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clang-reorder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Build without -Wno-pointer-sign. BUG=505303 Committed: https://crrev.com/5ebd5b30965afd047b3f3feb50da9f0fe78e71f6 Cr-Commit-Position: refs/heads/master@{#338464}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Sam McNally
5 years, 5 months ago (2015-07-10 02:48:15 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-10 02:48:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223363004/1
5 years, 5 months ago (2015-07-10 02:50:31 UTC) #5
commit-bot: I haz the power
Failed to apply patch for build/common.gypi: While running git apply --index -3 -p1; error: patch ...
5 years, 5 months ago (2015-07-10 04:18:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223363004/20001
5 years, 5 months ago (2015-07-13 01:17:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 02:29:12 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 02:30:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ebd5b30965afd047b3f3feb50da9f0fe78e71f6
Cr-Commit-Position: refs/heads/master@{#338464}

Powered by Google App Engine
This is Rietveld 408576698