Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1234413006: Move the Web Bluetooth implementation from child/ to renderer/. (Closed)

Created:
5 years, 5 months ago by Jeffrey Yasskin
Modified:
5 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, ortuno, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the Web Bluetooth implementation from child/ to renderer/. Since requestDevice() uses the Frame, and we don't support workers yet, jochen@ wants us to implement in renderer/ for now. This is the second of a 3-patch sequence: 1. Attach a frame-specific WebBluetooth in Blink. (https://codereview.chromium.org/1228283003) 2. Move Web Bluetooth from content/child/ to content/renderer/ (This patch) 3. Put the RenderFrame's ID in that WebBluetooth and plumb it back to the browser. (https://codereview.chromium.org/1228113004/) BUG=500989 Committed: https://crrev.com/f89a11b5f43fe6c3a0f31466fdf83f65c5d08f10 Cr-Commit-Position: refs/heads/master@{#339573}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -758 lines) Patch
M content/child/blink_platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download
D content/child/bluetooth/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/child/bluetooth/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D content/child/bluetooth/PRESUBMIT.py View 1 chunk +0 lines, -14 lines 0 comments Download
D content/child/bluetooth/bluetooth_dispatcher.h View 1 chunk +0 lines, -143 lines 0 comments Download
D content/child/bluetooth/bluetooth_dispatcher.cc View 1 chunk +0 lines, -387 lines 0 comments Download
D content/child/bluetooth/bluetooth_message_filter.h View 1 chunk +0 lines, -30 lines 0 comments Download
D content/child/bluetooth/bluetooth_message_filter.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D content/child/bluetooth/web_bluetooth_impl.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/child/bluetooth/web_bluetooth_impl.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
A + content/renderer/bluetooth/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/bluetooth/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/bluetooth/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/bluetooth/bluetooth_dispatcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/bluetooth/bluetooth_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/bluetooth/bluetooth_message_filter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/bluetooth/bluetooth_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/renderer/bluetooth/web_bluetooth_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/bluetooth/web_bluetooth_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
Jeffrey Yasskin
For posterity, Jochen's request is in https://codereview.chromium.org/1228113004/#msg14.
5 years, 5 months ago (2015-07-16 22:46:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-17 09:29:02 UTC) #3
scheib
LGTM
5 years, 5 months ago (2015-07-17 19:15:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234413006/1
5 years, 5 months ago (2015-07-17 23:52:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/79949)
5 years, 5 months ago (2015-07-18 00:01:25 UTC) #8
Jeffrey Yasskin
Arman, can you approve for ** Presubmit ERRORS ** Missing LGTM from OWNERS of dependencies ...
5 years, 5 months ago (2015-07-18 00:03:11 UTC) #10
armansito
lgtm
5 years, 5 months ago (2015-07-20 23:01:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234413006/20001
5 years, 5 months ago (2015-07-20 23:02:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 00:27:57 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 00:28:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f89a11b5f43fe6c3a0f31466fdf83f65c5d08f10
Cr-Commit-Position: refs/heads/master@{#339573}

Powered by Google App Engine
This is Rietveld 408576698