Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: src/trusted/validator/ncvalidate.h

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Fixing nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/ncvalidate.h
diff --git a/src/trusted/validator/ncvalidate.h b/src/trusted/validator/ncvalidate.h
index a06f53e9114d0b92e0923773afa16c212bff8b73..e104b67630a558a400d4550955b9de4ff6a5049e 100644
--- a/src/trusted/validator/ncvalidate.h
+++ b/src/trusted/validator/ncvalidate.h
@@ -20,6 +20,14 @@ EXTERN_C_BEGIN
struct NaClValidationCache;
struct NaClValidationMetadata;
+/* Defines possible validation flags. */
+typedef enum NaClValidationFlags {
+ DISABLE_NONTEMPORALS = 0x1,
+ X86_VALIDATION_FLAGS_MASK = 0x1,
Mark Seaborn 2015/07/29 16:09:23 Nit: these should really have a "NACL_" prefix to
+ ARM_VALIDATION_FLAGS_MASK = 0x0,
+ MIPS_VALIDATION_FLAGS_MASK = 0x0
+} NaClValidationFlags;
+
/* Defines possible validation status values. */
typedef enum NaClValidationStatus {
/* The call to the validator succeeded. */
@@ -63,6 +71,7 @@ typedef NaClValidationStatus (*NaClValidateFunc)(
uint8_t *data,
size_t size,
int stubout_mode,
+ uint32_t flags,
int readonly_text,
const NaClCPUFeatures *cpu_features,
const struct NaClValidationMetadata *metadata,

Powered by Google App Engine
This is Rietveld 408576698