src/trusted/validator/validation_cache_test.cc - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/validation_cache_test.cc

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Fixing nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/ncvalidate.h ('K') | « src/trusted/validator/ncvalidate.h ('k') | src/trusted/validator/validation_disable_nontemporals_test.cc » ('j') | src/trusted/validator_arm/ncvalidate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/validation_cache_test.cc

diff --git a/src/trusted/validator/validation_cache_test.cc b/src/trusted/validator/validation_cache_test.cc

index 0d430aa1637c4fd1143c726ab9cbe008601c269e..2bb5a2dfce5eb32b0d44e9cb0d38e8b200eeec16 100644

--- a/src/trusted/validator/validation_cache_test.cc

+++ b/src/trusted/validator/validation_cache_test.cc

@@ -168,6 +168,7 @@ class ValidationCachingInterfaceTests : public ::testing::Test {

NaClValidationStatus Validate() {

return validator->Validate(0, code_buffer, 32,

FALSE, /* stubout_mode */

+ 0, /* flags */

FALSE, /* readonly_test */

cpu_features,

metadata_ptr,

@@ -194,6 +195,7 @@ TEST_F(ValidationCachingInterfaceTests, NoCache) {

NaClValidationStatus status = validator->Validate(

0, code_buffer, CODE_SIZE,

FALSE, /* stubout_mode */

+ 0, /* flags */

FALSE, /* readonly_test */

cpu_features,

NULL, /* metadata */