Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: Source/core/svg/SVGLength.idl

Issue 1234383003: Removing TreatNullAs=NullString from SVGAngle.valueAsString and SVGLength.valueAsString attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAngle.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGLength.idl
diff --git a/Source/core/svg/SVGLength.idl b/Source/core/svg/SVGLength.idl
index 52e2daafd47f846a72010b751e74a3cef7af6d58..9d424706f8de7d52c75138482cee9149c6c1c680 100644
--- a/Source/core/svg/SVGLength.idl
+++ b/Source/core/svg/SVGLength.idl
@@ -22,7 +22,6 @@
// http://www.w3.org/TR/SVG2/types.html#InterfaceSVGLength
-// TODO(philipj): SVGLength should have constructors. crbug.com/366541
[
ImplementedAs=SVGLengthTearOff,
SetWrapperReferenceTo(SVGElement contextElement),
@@ -47,8 +46,7 @@
readonly attribute unsigned short unitType;
[RaisesException] attribute float value;
[RaisesException=Setter] attribute float valueInSpecifiedUnits;
- // TODO(philipj): valueAsString should not have [TreatNullAs=NullString].
- [TreatNullAs=NullString, RaisesException=Setter] attribute DOMString valueAsString;
+ [RaisesException=Setter] attribute DOMString valueAsString;
[RaisesException] void newValueSpecifiedUnits(unsigned short unitType, float valueInSpecifiedUnits);
[RaisesException] void convertToSpecifiedUnits(unsigned short unitType);
« no previous file with comments | « Source/core/svg/SVGAngle.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698