Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: Source/core/svg/SVGAngle.idl

Issue 1234383003: Removing TreatNullAs=NullString from SVGAngle.valueAsString and SVGLength.valueAsString attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt ('k') | Source/core/svg/SVGLength.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAngle.idl
diff --git a/Source/core/svg/SVGAngle.idl b/Source/core/svg/SVGAngle.idl
index 4c02f716d2b4a0236ac34adbda491e4dc4524d76..12320a3a07df9fd5275d9bdf4629c5f8c11a22d9 100644
--- a/Source/core/svg/SVGAngle.idl
+++ b/Source/core/svg/SVGAngle.idl
@@ -22,7 +22,6 @@
// http://www.w3.org/TR/SVG2/types.html#InterfaceSVGAngle
-// TODO(philipj): SVGAngle should have constructors. crbug.com/366541
[
ImplementedAs=SVGAngleTearOff,
SetWrapperReferenceTo(SVGElement contextElement),
@@ -39,8 +38,7 @@
readonly attribute unsigned short unitType;
[RaisesException=Setter] attribute float value;
[RaisesException=Setter] attribute float valueInSpecifiedUnits;
- // TODO(philipj): valueAsString should not have [TreatNullAs=NullString].
- [TreatNullAs=NullString, RaisesException=Setter] attribute DOMString valueAsString;
+ [RaisesException=Setter] attribute DOMString valueAsString;
[RaisesException] void newValueSpecifiedUnits(unsigned short unitType, float valueInSpecifiedUnits);
[RaisesException] void convertToSpecifiedUnits(unsigned short unitType);
« no previous file with comments | « LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt ('k') | Source/core/svg/SVGLength.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698