Issue 1234343006: Some miscellaneous fixes:

Issue 1234343006: Some miscellaneous fixes: (Closed)

Created:
5 years, 5 months ago by iannucci

Modified:
5 years, 5 months ago

Reviewers:
dnj, Vadim Sh., estaab, martiniss

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Some miscellaneous fixes * Fix DSKeyIncomplete to check for nil * Fix docstring in memory/context.go * Make GlobalInfo support BrokenFeatures * Fix memory TaskQueue to fill in the default queue name, per SDK spec. R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/fdd4957b5b087d17d15b72838e95319bff48d25c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -16 lines)			Patch
M	go/src/infra/gae/libs/gae/helper/datastore_key.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	go/src/infra/gae/libs/gae/memory/context.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	go/src/infra/gae/libs/gae/memory/globalinfo.go	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	go/src/infra/gae/libs/gae/memory/taskqueue_data.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	go/src/infra/gae/libs/gae/memory/taskqueue_test.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Dependent Patchsets:

Total messages: 6 (1 generated)

iannucci

On 2015/07/16 23:13:16, iannucci wrote: PTAL, also short (if not a bit miscellaneous)

5 years, 5 months ago (2015-07-16 23:13:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234343006/1

5 years, 5 months ago (2015-07-16 23:17:25 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 23:20:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/fdd4957b5b087d17d15b72838e953...