go/src/infra/gae/libs/gae/helper/datastore_key.go - Issue 1234343006: Some miscellaneous fixes:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/gae/libs/gae/helper/datastore_key.go

Issue 1234343006: Some miscellaneous fixes: (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: go/src/infra/gae/libs/gae/helper/datastore_key.go

diff --git a/go/src/infra/gae/libs/gae/helper/datastore_key.go b/go/src/infra/gae/libs/gae/helper/datastore_key.go

index 21734e1e7a0c891bf6930dd7e6d3f74adca6e7a9..35d48a56ea625b5822ca3f766db242cfcd63fc12 100644

--- a/go/src/infra/gae/libs/gae/helper/datastore_key.go

+++ b/go/src/infra/gae/libs/gae/helper/datastore_key.go

@@ -116,7 +116,7 @@ func DSKeyUnmarshalJSON(buf []byte) (appID, namespace string, toks []gae.DSKeyTo

// DSKeyIncomplete returns true iff k doesn't have an id yet.

func DSKeyIncomplete(k gae.DSKey) bool {

- return k.StringID() == "" && k.IntID() == 0

+ return k != nil && k.StringID() == "" && k.IntID() == 0

}

// DSKeyValid determines if a key is valid, according to a couple rules:

« no previous file with comments | « no previous file | go/src/infra/gae/libs/gae/memory/context.go » ('j') | no next file with comments »