Issue 1234333002: Don't throw "line too long" presubmit error on python import statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234333002: Don't throw "line too long" presubmit error on python import statements. (Closed)

Created:
5 years, 5 months ago by aiolos (Not reviewing)

Modified:
5 years, 5 months ago

Reviewers:
Dirk Pranke, dpranke

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

Don't throw "line too long" presubmit error on python import statements or when pylint "line too long" is disabled. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296035

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	presubmit_canned_checks.py	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234333002/20001

5 years, 5 months ago (2015-07-16 01:25:33 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 01:27:17 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296035