Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1234313002: Make readpixels work on GrTextures (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : fix and more kRT removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -107 lines) Patch
M include/gpu/GrContext.h View 2 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 7 chunks +50 lines, -28 lines 0 comments Download
M src/gpu/GrSurface.cpp View 2 chunks +51 lines, -6 lines 0 comments Download
M src/gpu/GrSurfacePriv.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +6 lines, -32 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 14 chunks +78 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 5 months ago (2015-07-16 15:08:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234313002/40001
5 years, 5 months ago (2015-07-16 15:08:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-16 15:16:58 UTC) #6
joshualitt
On 2015/07/16 15:08:56, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 5 months ago (2015-07-16 15:17:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234313002/40001
5 years, 5 months ago (2015-07-16 15:22:31 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 15:23:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e8d21e8f24aa676765d0ff8f433228665c75cdc2

Powered by Google App Engine
This is Rietveld 408576698