src/image/SkImage_Gpu.cpp - Issue 1234313002: Make readpixels work on GrTextures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage_Gpu.cpp

Issue 1234313002: Make readpixels work on GrTextures (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix and more kRT removal Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkImage_Gpu.cpp

diff --git a/src/image/SkImage_Gpu.cpp b/src/image/SkImage_Gpu.cpp

index a3fe022b437e0e8d838051be77dc6b5c4cdd8ad3..31ae5a90fdebdd58c0b03c87f9e790a88d9728d2 100644

--- a/src/image/SkImage_Gpu.cpp

+++ b/src/image/SkImage_Gpu.cpp

@@ -248,8 +248,6 @@ GrTexture* GrDeepCopyTexture(GrTexture* src, bool budgeted) {

GrContext* ctx = src->getContext();

GrSurfaceDesc desc = src->desc();

- // need to be a rendertarget for readpixels to work, instead of kNone_GrSurfaceFlags

- desc.fFlags = kRenderTarget_GrSurfaceFlag;

GrTexture* dst = ctx->textureProvider()->createTexture(desc, budgeted, NULL, 0);

if (!dst) {

return NULL;

« no previous file with comments | « src/gpu/gl/GrGLGpu.cpp ('k') | tests/ReadPixelsTest.cpp » ('j') | no next file with comments »