Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

Issue 123423002: Fix checkedInstructionOrNonGenerateAtUseSite. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Don't try to improve var-allocator. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart
index 2caf6410e93999ea6cf039426b1dda21cbc461fa..97628a04c0a5b4a0a03e17db2baa7f914345f9bc 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart
@@ -116,11 +116,7 @@ class SsaInstructionSelection extends HBaseVisitor {
HInstruction interceptor = node.inputs[0];
HInstruction receiverArgument = node.inputs[1];
- // TODO(15720): The test here should be
- //
- // interceptor.nonCheck() == receiverArgument.nonCheck()
- //
- if (interceptor == receiverArgument) {
+ if (interceptor.nonCheck() == receiverArgument.nonCheck()) {
// TODO(15933): Make automatically generated property extraction
// closures work with the dummy receiver optimization.
if (!selector.isGetter()) {

Powered by Google App Engine
This is Rietveld 408576698