Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

Issue 123423002: Fix checkedInstructionOrNonGenerateAtUseSite. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Don't try to improve var-allocator. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 /** 7 /**
8 * Replaces some instructions with specialized versions to make codegen easier. 8 * Replaces some instructions with specialized versions to make codegen easier.
9 * Caches codegen information on nodes. 9 * Caches codegen information on nodes.
10 */ 10 */
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // t1.foo$1(t1, x) 109 // t1.foo$1(t1, x)
110 // ---> 110 // --->
111 // b.get$thing().foo$1(0, x) 111 // b.get$thing().foo$1(0, x)
112 // 112 //
113 Selector selector = node.selector; 113 Selector selector = node.selector;
114 if (backend.isInterceptedSelector(selector) && 114 if (backend.isInterceptedSelector(selector) &&
115 !backend.isInterceptedMixinSelector(selector)) { 115 !backend.isInterceptedMixinSelector(selector)) {
116 HInstruction interceptor = node.inputs[0]; 116 HInstruction interceptor = node.inputs[0];
117 HInstruction receiverArgument = node.inputs[1]; 117 HInstruction receiverArgument = node.inputs[1];
118 118
119 // TODO(15720): The test here should be 119 if (interceptor.nonCheck() == receiverArgument.nonCheck()) {
120 //
121 // interceptor.nonCheck() == receiverArgument.nonCheck()
122 //
123 if (interceptor == receiverArgument) {
124 // TODO(15933): Make automatically generated property extraction 120 // TODO(15933): Make automatically generated property extraction
125 // closures work with the dummy receiver optimization. 121 // closures work with the dummy receiver optimization.
126 if (!selector.isGetter()) { 122 if (!selector.isGetter()) {
127 Constant constant = new DummyConstant( 123 Constant constant = new DummyConstant(
128 receiverArgument.instructionType); 124 receiverArgument.instructionType);
129 HConstant dummy = graph.addConstant(constant, compiler); 125 HConstant dummy = graph.addConstant(constant, compiler);
130 receiverArgument.usedBy.remove(node); 126 receiverArgument.usedBy.remove(node);
131 node.inputs[1] = dummy; 127 node.inputs[1] = dummy;
132 dummy.usedBy.add(node); 128 dummy.usedBy.add(node);
133 } 129 }
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 } 694 }
699 695
700 // If [thenInput] is defined in the first predecessor, then it is only used 696 // If [thenInput] is defined in the first predecessor, then it is only used
701 // by [phi] and can be generated at use site. 697 // by [phi] and can be generated at use site.
702 if (identical(thenInput.block, end.predecessors[0])) { 698 if (identical(thenInput.block, end.predecessors[0])) {
703 assert(thenInput.usedBy.length == 1); 699 assert(thenInput.usedBy.length == 1);
704 markAsGenerateAtUseSite(thenInput); 700 markAsGenerateAtUseSite(thenInput);
705 } 701 }
706 } 702 }
707 } 703 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698