make menus, bubbles, etc. top level windows on aura

chrome/browser/ui/views/chrome_views_delegate.cc

Index: chrome/browser/ui/views/chrome_views_delegate.cc
diff --git a/chrome/browser/ui/views/chrome_views_delegate.cc b/chrome/browser/ui/views/chrome_views_delegate.cc
index 60c16e7fe24f28f5aa15e0fcda9364ef8d40fb9c..62573b1ea5a67ef522e83c38a6109b3338dc2393 100644
--- a/chrome/browser/ui/views/chrome_views_delegate.cc
+++ b/chrome/browser/ui/views/chrome_views_delegate.cc
@@ -214,8 +214,14 @@ void ChromeViewsDelegate::OnBeforeWidgetInit(
       default:
         NOTREACHED();
     }
+#if defined(OS_WIN) && defined(USE_AURA)

[sky, 2013/03/14 20:06:37]

Why is this windows specific, don't we want it for aura non-chromeos?

Also, we shouldn't need this for HOST_DESKTOP_TYPE_ASH right?

Lastly, add a comment in the body describing why we have this logic, that is,
what the empty else does and why we want it.

[scottmg, 2013/03/14 22:51:53]

I'm not clear on what's possible on Linux. I don't know if we can blend other
top-level windows with the main window, so I was focusing on Windows for now.
Done.
Done.

+  } else if (params->parent &&
+             (params->type == views::Widget::InitParams::TYPE_CONTROL ||
+              params->type == views::Widget::InitParams::TYPE_WINDOW)) {
+#else
   } else if (params->parent &&
              params->type != views::Widget::InitParams::TYPE_MENU) {
+#endif
     params->native_widget = new views::NativeWidgetAura(delegate);
   } else if (params->type != views::Widget::InitParams::TYPE_TOOLTIP) {
     // TODO(erg): Once we've threaded context to everywhere that needs it, we