make menus, bubbles, etc. top level windows on aura

chrome/browser/ui/views/chrome_views_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_views_delegate.h"
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
@@ skipping 196 matching lines @@
         break;
 #if defined(USE_ASH)
       case chrome::HOST_DESKTOP_TYPE_ASH:
         // If we're in ash, give this window the context of the main monitor.
         params->context = ash::Shell::GetPrimaryRootWindow();
         break;
 #endif
       default:
         NOTREACHED();
     }
+#if defined(OS_WIN) && defined(USE_AURA)

[sky, 2013/03/14 20:06:37]

Why is this windows specific, don't we want it for aura non-chromeos?

Also, we shouldn't need this for HOST_DESKTOP_TYPE_ASH right?

Lastly, add a comment in the body describing why we have this logic, that is,
what the empty else does and why we want it.

[scottmg, 2013/03/14 22:51:53]

I'm not clear on what's possible on Linux. I don't know if we can blend other
top-level windows with the main window, so I was focusing on Windows for now.
Done.
Done.

+  } else if (params->parent &&
+             (params->type == views::Widget::InitParams::TYPE_CONTROL ||
+              params->type == views::Widget::InitParams::TYPE_WINDOW)) {
+#else
   } else if (params->parent &&
              params->type != views::Widget::InitParams::TYPE_MENU) {
+#endif
     params->native_widget = new views::NativeWidgetAura(delegate);
   } else if (params->type != views::Widget::InitParams::TYPE_TOOLTIP) {
     // TODO(erg): Once we've threaded context to everywhere that needs it, we
     // should remove this check here.
     gfx::NativeView to_check =
         params->context ? params->context : params->parent;
     if (chrome::GetHostDesktopTypeForNativeView(to_check) ==
         chrome::HOST_DESKTOP_TYPE_NATIVE) {
       params->native_widget = new views::DesktopNativeWidgetAura(delegate);
     }
   }
 #endif
 }