Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 1234103002: Plugin Power Saver: Center 'Play' icon for all partially obscured plugins. (Closed)

Created:
5 years, 5 months ago by tommycli
Modified:
5 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Center 'Play' icon for all partially obscured plugins. This centers the 'Play' icon correctly even if the plugin's left side or top side is obscured. BUG=503771 Committed: https://crrev.com/5ffce36e4eb2986a39172dd26f8f9a8cef8308a3 Cr-Commit-Position: refs/heads/master@{#338717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M chrome/renderer/resources/plugins/plugin_poster.html View 1 chunk +6 lines, -0 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 4 chunks +28 lines, -23 lines 0 comments Download
M components/plugins/renderer/webview_plugin.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
tommycli
bauerb: ptal, thanks!
5 years, 5 months ago (2015-07-14 16:52:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234103002/1
5 years, 5 months ago (2015-07-14 16:52:28 UTC) #4
Bernhard Bauer
lgtm
5 years, 5 months ago (2015-07-14 17:03:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234103002/1
5 years, 5 months ago (2015-07-14 17:49:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 18:25:55 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 18:27:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ffce36e4eb2986a39172dd26f8f9a8cef8308a3
Cr-Commit-Position: refs/heads/master@{#338717}

Powered by Google App Engine
This is Rietveld 408576698