components/plugins/renderer/loadable_plugin_placeholder.h - Issue 1234103002: Plugin Power Saver: Center 'Play' icon for all partially obscured plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 1234103002: Plugin Power Saver: Center 'Play' icon for all partially obscured plugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/plugins/plugin_poster.html ('k') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/loadable_plugin_placeholder.h

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h

index 13b903df92292b05a8b89888a37542471a0151f7..0221a0ffbc6cd1d4c8c7f3447e0610dbf3583ebe 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.h

+++ b/components/plugins/renderer/loadable_plugin_placeholder.h

@@ -76,7 +76,7 @@ class LoadablePluginPlaceholder : public PluginPlaceholderBase {

void PluginDestroyed() override;

v8::Local<v8::Object> GetV8ScriptableObject(

v8::Isolate* isolate) const override;

- void OnUnobscuredSizeUpdate(const gfx::Size& unobscured_size) override;

+ void OnUnobscuredRectUpdate(const gfx::Rect& unobscured_rect) override;

// RenderFrameObserver methods:

void WasShown() override;

@@ -118,7 +118,7 @@ class LoadablePluginPlaceholder : public PluginPlaceholderBase {

// Used to prevent re-entrancy during the size recheck for throttled plugins.

bool in_size_recheck_;

- gfx::Size unobscured_size_;

+ gfx::Rect unobscured_rect_;

base::OneShotTimer<LoadablePluginPlaceholder> size_update_timer_;

base::WeakPtrFactory<LoadablePluginPlaceholder> weak_factory_;

« no previous file with comments | « chrome/renderer/resources/plugins/plugin_poster.html ('k') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | no next file with comments »