testing/embedder_test.cpp - Issue 1234053003: Plumb in an externally created v8::Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/embedder_test.cpp

Issue 1234053003: Plumb in an externally created v8::Isolate (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/embedder_test.cpp

diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp

index ee2ad086a7250cfa10ef6607b1faa4e154f31305..02d0fae789ab643e4479552f4f649e7966ed36bd 100644

--- a/testing/embedder_test.cpp

+++ b/testing/embedder_test.cpp

@@ -212,7 +212,7 @@ bool EmbedderTest::OpenDocument(const std::string& filename) {

IPDF_JSPLATFORM* platform = static_cast<IPDF_JSPLATFORM*>(this);

memset(platform, 0, sizeof(IPDF_JSPLATFORM));

- platform->version = 1;

+ platform->version = 2;

platform->app_alert = AlertTrampoline;

FPDF_FORMFILLINFO* formfillinfo = static_cast<FPDF_FORMFILLINFO*>(this);

« public/fpdf_formfill.h ('K') | « samples/pdfium_test.cc ('k') | no next file » | no next file with comments »