samples/pdfium_test.cc - Issue 1234053003: Plumb in an externally created v8::Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/pdfium_test.cc

Issue 1234053003: Plumb in an externally created v8::Isolate (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/pdfium_test.cc

diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc

index 5147266c99e71f382b4b04a14030301b930868b9..7e9ca68cef942d8033dd354c23543a3daad0baa3 100644

--- a/samples/pdfium_test.cc

+++ b/samples/pdfium_test.cc

@@ -426,7 +426,7 @@ void RenderPdf(const std::string& name, const char* pBuf, size_t len,

IPDF_JSPLATFORM platform_callbacks;

memset(&platform_callbacks, '\0', sizeof(platform_callbacks));

- platform_callbacks.version = 1;

+ platform_callbacks.version = 2;

platform_callbacks.app_alert = ExampleAppAlert;

platform_callbacks.Doc_gotoPage = ExampleDocGotoPage;