Plumb in an externally created v8::Isolate

public/fpdf_formfill.h

Index: public/fpdf_formfill.h
diff --git a/public/fpdf_formfill.h b/public/fpdf_formfill.h
index a1b9ec2a775e03b25659c2c45a262c65c39578f6..a06067526d736939b64b1c2d6df860c28134584a 100644
--- a/public/fpdf_formfill.h
+++ b/public/fpdf_formfill.h
@@ -11,6 +11,10 @@
 
 typedef void* FPDF_FORMHANDLE;
 
+namespace v8 {

[tsepez (do not use), 2015/07/14 17:02:29]

Actually, these public files are expected to compile under C or C++, so you
don't get to use namespaces and classes.  Sadly, your isolate will need to be a
void* (I can hear the sound of revulsion coming across the atlantic ...)

+class Isolate;
+}
+
 // Exported Functions
 #ifdef __cplusplus
 extern "C" {
@@ -19,7 +23,8 @@ extern "C" {
 typedef struct _IPDF_JsPlatform
 {
 /**
-* Version number of the interface. Currently must be 1.
+* Version number of the interface. Currently must be 1 or 2 (in the latter case

[Tom Sepez, 2015/07/14 16:29:27]

nit: probably just say "Currently must be 2."

+* m_isolate must be set).
     **/
     int version;
 
@@ -222,6 +227,11 @@ typedef struct _IPDF_JsPlatform
     *   pointer to FPDF_FORMFILLINFO interface.
     **/
     void*   m_pFormfillinfo;
+

[Tom Sepez, 2015/07/14 16:29:27]

nit: comment like
   /* Version 2. */

+    /**
+    *   pointer to the v8::Isolate to use.

[Tom Sepez, 2015/07/14 16:29:27]

nit: , or NULL to force PDFIUm to create one.

+    **/
+    v8::Isolate*   m_isolate;
 } IPDF_JSPLATFORM;
 
 // Flags for Cursor type