Plumb in an externally created v8::Isolate

public/fpdf_formfill.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef PUBLIC_FPDF_FORMFILL_H_
 #define PUBLIC_FPDF_FORMFILL_H_
 
 #include "fpdfview.h"
 
 typedef void* FPDF_FORMHANDLE;
 
+namespace v8 {

[tsepez (do not use), 2015/07/14 17:02:29]

Actually, these public files are expected to compile under C or C++, so you
don't get to use namespaces and classes.  Sadly, your isolate will need to be a
void* (I can hear the sound of revulsion coming across the atlantic ...)

+class Isolate;
+}
+
 // Exported Functions
 #ifdef __cplusplus
 extern "C" {
 #endif
 
 typedef struct _IPDF_JsPlatform
 {
 /**
-* Version number of the interface. Currently must be 1.
+* Version number of the interface. Currently must be 1 or 2 (in the latter case

[Tom Sepez, 2015/07/14 16:29:27]

nit: probably just say "Currently must be 2."

+* m_isolate must be set).
     **/
     int version;
 
     /**

[Tom Sepez, 2015/07/14 16:29:27]

nit: Comment here like 
   /* Version 1. */
before the comments for the set of members present in V1.

     * Method: app_alert
     *           pop up a dialog to show warning or hint.
     * Interface Version:
     *           1
     * Implementation Required:
     *           yes
     * Parameters:
     *           pThis       -   Pointer to the interface structure itself
     *           Msg         -   A string containing the message to be displayed.
     *           Title       -   The title of the dialog.
@@ skipping 178 matching lines @@
     *       Number of bytes the filePath consumes, including trailing zeros.
     * Comments:
     *       The filePath shoule be always input in local encoding.
     */
     int  (*Field_browse)(struct _IPDF_JsPlatform* pThis,void* filePath, int length);
 
     /**
     *   pointer to FPDF_FORMFILLINFO interface.
     **/
     void*   m_pFormfillinfo;
+

[Tom Sepez, 2015/07/14 16:29:27]

nit: comment like
   /* Version 2. */

+    /**
+    *   pointer to the v8::Isolate to use.

[Tom Sepez, 2015/07/14 16:29:27]

nit: , or NULL to force PDFIUm to create one.

+    **/
+    v8::Isolate*   m_isolate;
 } IPDF_JSPLATFORM;
 
 // Flags for Cursor type
 #define FXCT_ARROW  0
 #define FXCT_NESW   1
 #define FXCT_NWSE   2
 #define FXCT_VBEAM  3
 #define FXCT_HBEAM  4
 #define FXCT_HAND   5
 
@@ skipping 591 matching lines @@
 **/
 DLLEXPORT void STDCALL FPDF_FFLDraw(FPDF_FORMHANDLE hHandle,FPDF_BITMAP bitmap, FPDF_PAGE page, int start_x, int start_y,
                         int size_x, int size_y, int rotate, int flags);
 
 
 #ifdef __cplusplus
 }
 #endif
 
 #endif  // PUBLIC_FPDF_FORMFILL_H_