Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate

chrome/browser/autofill/test_autofill_manager_delegate.h

Index: chrome/browser/autofill/test_autofill_manager_delegate.h
diff --git a/chrome/browser/autofill/test_autofill_manager_delegate.h b/chrome/browser/autofill/test_autofill_manager_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..93acc3b6da74c83409c499f9b50566d70d3a6494
--- /dev/null
+++ b/chrome/browser/autofill/test_autofill_manager_delegate.h
@@ -0,0 +1,56 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_TEST_AUTOFILL_MANAGER_DELEGATE_H_
+#define CHROME_BROWSER_AUTOFILL_TEST_AUTOFILL_MANAGER_DELEGATE_H_
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/autofill/autofill_manager_delegate.h"
+
+namespace autofill {
+
+// This class is only for easier writing of testings. All pure virtual functions
+// have been giving empty methods.
+class TestAutofillManagerDelegate : public AutofillManagerDelegate {

[Ilya Sherman, 2013/02/26 09:24:57]

nit: IMO this is more of a "MockAutofillManagerDelegate", since all it does is
define the pure virtual functions with the minimal empty bodies; it doesn't
actually wire anything up to make methods like GetPersonalDataManager() work
nicely in tests.

[kaiwang, 2013/02/26 22:18:40]

As you can see in this CL, there are many other classes sub-class this one and
mock some methods so we can set expectations.
I'd prefer to call them "Mock". This one is just a useless "Fake". So I followed
"TestAutofillExternalDelegate" to name it.

See: http://en.wikipedia.org/wiki/Mock_object
"Mock objects in this sense do a little more: their method implementations
contain assertions of their own. This means that a true mock, in this sense,
will examine the context of each call— perhaps checking the order in which its
methods are called, perhaps performing tests on the data passed into the method
calls as arguments."

+ public:
+  virtual ~TestAutofillManagerDelegate();
+
+  // AutofillManagerDelegate implementation.
+  virtual InfoBarService* GetInfoBarService() OVERRIDE;
+  virtual PersonalDataManager* GetPersonalDataManager() OVERRIDE;
+  virtual PrefService* GetPrefs() OVERRIDE;
+  virtual ProfileSyncServiceBase* GetProfileSyncService() OVERRIDE;
+  virtual void HideRequestAutocompleteDialog() OVERRIDE;
+  virtual bool IsSavingPasswordsEnabled() const OVERRIDE;
+  virtual void OnAutocheckoutError() OVERRIDE;
+  virtual void ShowAutofillSettings() OVERRIDE;
+  virtual void ShowPasswordGenerationBubble(
+      const gfx::Rect& bounds,
+      const content::PasswordForm& form,
+      autofill::PasswordGenerator* generator) OVERRIDE;
+  virtual void ShowAutocheckoutBubble(
+      const gfx::RectF& bounding_box,
+      const gfx::NativeView& native_view,
+      const base::Closure& callback) OVERRIDE;
+  virtual void ShowRequestAutocompleteDialog(
+      const FormData& form,
+      const GURL& source_url,
+      const content::SSLStatus& ssl_status,
+      const AutofillMetrics& metric_logger,
+      DialogType dialog_type,
+      const base::Callback<void(const FormStructure*)>& callback) OVERRIDE;
+  virtual void RequestAutocompleteDialogClosed() OVERRIDE;
+  virtual void ShowAutofillPopup(const gfx::RectF& element_bounds,
+                                 const std::vector<string16>& values,
+                                 const std::vector<string16>& labels,
+                                 const std::vector<string16>& icons,
+                                 const std::vector<int>& identifiers,
+                                 AutofillPopupDelegate* delegate) OVERRIDE;
+  virtual void HideAutofillPopup() OVERRIDE;
+  virtual void UpdateProgressBar(double value) OVERRIDE;
+};
+
+}  // namespace autofill
+
+#endif  // CHROME_BROWSER_AUTOFILL_TEST_AUTOFILL_MANAGER_DELEGATE_H_