chrome/browser/autofill/test_autofill_external_delegate.cc - Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/test_autofill_external_delegate.cc

Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address most review comments and fix unit_tests Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/test_autofill_external_delegate.h ('K') | « chrome/browser/autofill/test_autofill_external_delegate.h ('k') | chrome/browser/autofill/test_autofill_manager_delegate.h » ('j') | chrome/browser/autofill/test_autofill_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/test_autofill_external_delegate.cc

diff --git a/chrome/browser/autofill/test_autofill_external_delegate.cc b/chrome/browser/autofill/test_autofill_external_delegate.cc

index 7bbdc239793e25beb531df3dca8bd38c6b7f2c89..5f4c380ecf19e72571ad13be6580d1f8a2e25f0a 100644

--- a/chrome/browser/autofill/test_autofill_external_delegate.cc

+++ b/chrome/browser/autofill/test_autofill_external_delegate.cc

@@ -26,6 +26,7 @@ void GenerateTestAutofillPopup(

query_id, autofill_item, autofill_item, autofill_item, autofill_id);

}

+/*

TestAutofillExternalDelegate::TestAutofillExternalDelegate(

content::WebContents* web_contents,

AutofillManager* autofill_manager)

@@ -47,5 +48,6 @@ void TestAutofillExternalDelegate::HideAutofillPopup() {}

void TestAutofillExternalDelegate::EnsurePopupForElement(

const gfx::RectF& element_bounds) {}

+ */

Ilya Sherman 2013/02/26 09:24:57 Here too, delete the code rather than commenting i

kaiwang 2013/02/26 22:18:40 Done.

} // namespace autofill