Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 12340052: Use boolean instead of Atomic32 for is_profiling_ flag (Closed)

Created:
7 years, 10 months ago by yurys
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Use boolean instead of Atomic32 for is_profiling_ flag The field is only accessed on the JS thread so it can be converted into bool. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=13731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/cpu-profiler.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/cpu-profiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 10 months ago (2013-02-25 14:08:19 UTC) #1
yurys
7 years, 10 months ago (2013-02-25 16:16:21 UTC) #2
Jakob Kummerow
lgtm
7 years, 10 months ago (2013-02-25 16:32:56 UTC) #3
yurys
7 years, 10 months ago (2013-02-26 12:28:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r13731.

Powered by Google App Engine
This is Rietveld 408576698