Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: src/cpu-profiler.h

Issue 12340052: Use boolean instead of Atomic32 for is_profiling_ flag (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/cpu-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cpu-profiler.h
diff --git a/src/cpu-profiler.h b/src/cpu-profiler.h
index 9cd44842095ccabe25d0ef74f0c0f0b53dde958d..61a0859529128e861cf7b0b54545ce5254b75f91 100644
--- a/src/cpu-profiler.h
+++ b/src/cpu-profiler.h
@@ -245,11 +245,9 @@ class CpuProfiler {
static void SetterCallbackEvent(String* name, Address entry_point);
static void SharedFunctionInfoMoveEvent(Address from, Address to);
- // TODO(isolates): this doesn't have to use atomics anymore.
-
static INLINE(bool is_profiling(Isolate* isolate)) {
CpuProfiler* profiler = isolate->cpu_profiler();
- return profiler != NULL && NoBarrier_Load(&profiler->is_profiling_);
+ return profiler != NULL && profiler->is_profiling_;
}
private:
@@ -271,7 +269,7 @@ class CpuProfiler {
ProfilerEventsProcessor* processor_;
int saved_logging_nesting_;
bool need_to_stop_sampler_;
- Atomic32 is_profiling_;
+ bool is_profiling_;
private:
DISALLOW_COPY_AND_ASSIGN(CpuProfiler);
« no previous file with comments | « no previous file | src/cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698