Issue 12340050: Add DISALLOW_COPY_AND_ASSIGN to subclasses of ValueObject and make ValueObject copyable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12340050: Add DISALLOW_COPY_AND_ASSIGN to subclasses of ValueObject and make ValueObject copyable.

Created:
7 years, 9 months ago by Florian Schneider

Modified:
7 years, 7 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add DISALLOW_COPY_AND_ASSIGN to subclasses of ValueObject and make ValueObject copyable. ValueObject as its name suggests can be passed by value and should be copyable and assignable. Almost all subclasses of ValueOject already disallow copying and assigning explicitly. For classes which should not be copied implicitly, prevent this explicitly by adding the DISALLOW_COPY_AND_ASSIGN. macro. Remove all copy constructors and assignment operators that duplicate the compiler generated default implementation.

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -160 lines)			Patch
M	runtime/vm/allocation.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/assembler.h	View	4 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.h	View	4 chunks	+0 lines, -26 lines	0 comments	Download
M	runtime/vm/assembler_ia32.h	View	6 chunks	+2 lines, -31 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	4 chunks	+0 lines, -25 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	6 chunks	+3 lines, -33 lines	0 comments	Download
M	runtime/vm/bit_vector.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/hash_map.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	7 chunks	+8 lines, -37 lines	0 comments	Download
M	runtime/vm/locations.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download